From today, "All discussions" is showing tags selected as "Hiding"

tariqthedev

harrrrrry The last deployment which contained that fix had to be undone last night due to a few other issues that popped up.

We are looking at what caused those issues and to rule out the fix to the third party extension as the cause.

Hopefully unrelated and we can get that back in.

harrrrrry

tariqthedev

OK, glad it’s understood.

Was https://community.giffgaff.com/d/33149486-oops-something-went-wrong-please-reload-the-page-and-try-again-x one of those other problems? As mentioned at https://community.giffgaff.com/d/33149486-oops-something-went-wrong-please-reload-the-page-and-try-again-x/22 and https://community.giffgaff.com/d/33149486-oops-something-went-wrong-please-reload-the-page-and-try-again-x/24 – but still a problem this morning.

I think I may also have not received some of the usual messages from educators after thread moves yesterday, though that could just be that the educators were busy doing other things.

tariqthedev

harrrrrry Yes that is one of the issues.

It’s going to be a bumpy start but hopefully we can smooth things over quickly.

tariqthedev

harrrrrry hidden tags feature should now be back.

endorphin

tariqthedev I wonder why these problems didn’t manifest in the preview site?

harrrrrry

endorphin

endorphin why these problems didn’t manifest in the preview site?

The preview site can’t easily be used to check out our normal day to day activities. But it works fine for specific tests which will mostly be geared around testing the new features. The problems that have been found are mostly with existing features that unexpectedly became broken and there’s no easy way to predict what might break because the preview site intentionally doesn’t share the live message base.

That doesn’t make the preview site worthless – it works for its intended purpose. But probably a further short test phase is needed, using the new software and the full live message base, between preview testing and release.

See https://preview.community.giffgaff.com/d/85-test-stage-beyond-preview-needed for a partial explanation.

harrrrrry

tariqthedev

Thanks for the notice – yes, seems good again.

endorphin

tariqthedev I’m still seeing the sub-tags “Hot Deals and Tips” and “Covid-19” which I have hidden in the parent tag view?

tariqthedev

endorphin If they are sticky discussions it doesn’t hide them - I believe that is by design.

harrrrrry

tariqthedev If they are sticky discussions it doesn’t hide them

I think probably your current fix is only working when displaying All Discussions but not when displaying other tags.

I have Hot Deals set to Hiding and sure enough they are gone from All Discussions. But they’re showing up in Tips and Guides

endorphin

tariqthedev If they are sticky discussions it doesn’t hide them

There are no stickied discussions in either of those sub-tags.

tariqthedev I believe that is by design.

Hmm, I hope not. If I hide a subtag I don’t expect to see any discussions, stickied or not! 😉

tariqthedev Will let the platform run as is for the next few days and revisit this on Monday.

Fair enuf.

@tariqthedev Possibly related but the various tag views seem to take longer to load than before?

tariqthedev

harrrrrry Ah I see what you mean.

Some of our older fixes/modifications may need to be updated to run against the latest Flarum core codebase.

Will let the platform run as is for the next few days and revisit this on Monday.

endorphin

frenchielove

tariqthedev Will let the platform run as is for the next few days and revisit this on Monday.

from here.

endorphin

tariqthedev please can we have the subtag hiding feature restored.

z201205

I really hope that tag hiding returns soon as general discussion is being overrun with covid19 posts.

alex_w

endorphin We’ll get this scheduled in to take a look at. We’re pretty sure we know why sub tags aren’t hiding from parent tags at the moment, so shouldn’t be too difficult a fix.

endorphin

alex_w thanks for the update. 🙂

endorphin

alex_w it looks like this has been fixed for subtags - well at least I can’t see the ones I’ve hidden. 🙂

harrrrrry

endorphin

Glad to hear it 🙂

alex_w

endorphin

It has indeed been fixed yesterday.