From today, "All discussions" is showing tags selected as "Hiding"

harrrrrry

It looks like the upgrade this morning has very seriously broken the tag selection.

Example: I have General Discussion set as Hiding because it’s not a tag I want to see by default.

This has worked up to this morning. But my usual bookmark https://community.giffgaff.com/all is now improperly overrun with General Discussion items:

I tried removing and reselecting Hiding in GD but it made no difference.

mrjeeves

harrrrrry

Great find!

tariqthedev

harrrrrry Thanks for flagging this. I will get this checked out ASAP.

The core platform upgrade was unfortunately necessary as it introduces a lot of bug fixes and takes us a step closer to Flarum’s stable release.

Will keep you posted on where we get with this.

harrrrrry

mrjeeves

I couldn’t miss it. First thread I was presented with this morning was a thread about devolution for Scotland which I was about to flag as Off Topic, when I noticed it was already correctly tagged as GD😮

mrjeeves

harrrrrry

Haha!

I don’t look at All Discussions so I would never have noticed

goofygirl

I cant respond to threads I have always responded to, its rubbish

mrjeeves

goofygirl

Try logging out and back in again. I’ve had a few issues until just now (when the upgrade should basically be finished by).

goofygirl

mrjeeves
Thankyou, that worked for me

tariqthedev

Hi @harrrrrry issue should be fixed now, there was a bug in a third party extension that we’ve resolved.

Any more issues just give us a shout.

harrrrrry

tariqthedev

Well done for getting it fixed so quickly.

Only other issue (so far) is that I can’t mark your post as Best Answer, but perhaps that has never been allowed in Feedback.

harrrrrry

tariqthedev

The fix seems to have “undone” itself this morning.

Today I’m getting General Discussion and other tags set as “Hiding” back in my All Discussions list – though they were all properly hidden yesterday afternoon.

tariqthedev

harrrrrry The last deployment which contained that fix had to be undone last night due to a few other issues that popped up.

We are looking at what caused those issues and to rule out the fix to the third party extension as the cause.

Hopefully unrelated and we can get that back in.

harrrrrry

tariqthedev

OK, glad it’s understood.

Was https://community.giffgaff.com/d/33149486-oops-something-went-wrong-please-reload-the-page-and-try-again-x one of those other problems? As mentioned at https://community.giffgaff.com/d/33149486-oops-something-went-wrong-please-reload-the-page-and-try-again-x/22 and https://community.giffgaff.com/d/33149486-oops-something-went-wrong-please-reload-the-page-and-try-again-x/24 – but still a problem this morning.

I think I may also have not received some of the usual messages from educators after thread moves yesterday, though that could just be that the educators were busy doing other things.

tariqthedev

harrrrrry Yes that is one of the issues.

It’s going to be a bumpy start but hopefully we can smooth things over quickly.

tariqthedev

harrrrrry hidden tags feature should now be back.

endorphin

tariqthedev I wonder why these problems didn’t manifest in the preview site?

harrrrrry

endorphin

endorphin why these problems didn’t manifest in the preview site?

The preview site can’t easily be used to check out our normal day to day activities. But it works fine for specific tests which will mostly be geared around testing the new features. The problems that have been found are mostly with existing features that unexpectedly became broken and there’s no easy way to predict what might break because the preview site intentionally doesn’t share the live message base.

That doesn’t make the preview site worthless – it works for its intended purpose. But probably a further short test phase is needed, using the new software and the full live message base, between preview testing and release.

See https://preview.community.giffgaff.com/d/85-test-stage-beyond-preview-needed for a partial explanation.

harrrrrry

tariqthedev

Thanks for the notice – yes, seems good again.

endorphin

tariqthedev I’m still seeing the sub-tags “Hot Deals and Tips” and “Covid-19” which I have hidden in the parent tag view?

tariqthedev

endorphin If they are sticky discussions it doesn’t hide them - I believe that is by design.