Several features suddenly broken

harrrrrry

Edit: All solved.

See https://community.giffgaff.com/d/33186722-several-features-suddenly-broken/15 for the solution

Note that these features need to be tested on desktop, not in the app. I’m testing in firefox 81.0.2 64 bit and using a separate tab of the same browser window to compare with the preview site at https://preview.community.giffgaff.com/d/88-test

Until a couple of days ago, it was possible to highlight text and use it as part of a quote.

It’s still possible on the preview site:

But no longer possible on the live site – the quote option no longer appears:

xxx
Until a couple of days ago, it was possible to paste an image from the clipboard straight in to a reply. It’s still possible on the preview site, which automatically uploads it, saves it as an image and creates markdown for the image. The above two images are examples – I pasted them into a message on the the preview site to get an image and then copied the generated markdown into the current message.

It’s no longer possible to do that on the live site. Attempting to paste images from clipboard now nothing at all.

xxx
yyy
Bullet numbering is broken. To get numbered bullets, I’m having to type in the numbers myself, instead of having the numbers auto generated.

On preview, it works like this:

On the live site, using the same buttons and keystrokes:

xxx
yyy
zzz
Control-B to generate bold text has become intermittent

Until recently, control-B started bold text mode – the same as pressing the B icon at the bottom of the compose box, but a thousand times more convenient. Now, after a while. control-B stops doing that and brings up my browser bookmarks instead. I’m not sure what triggers it to stop working, but it’s possibly attempting to do one of the first 3 problems. But this too is still working properly on the preview site.

xxx
yyy
zzz
AAA
@ mentions are partially broken

Until recently, it was possible to press return to paste when the correct user was highlighted and have the correct username appear in the text. For example, pressing return with this on screen:

would cause the full username to appear in the post.

But from yesterday, only the @ sign appears. It’s no longer sufficient to press return – you must double click the highlighted user for it to be copied.

danwillen

harrrrrry Until a couple of days ago, it was possible to highlight text and use it as part of a quote

Quote is working fine for me. Accessing community through the giffgaff app.

alex_w

harrrrrry I’m testing in firefox 81.0.2 64 bit

Can you try alternative browsers as well as a first trouble shoot?

Edit: Appears that quote works fine for me on desktop in Firefox 82.0.2 64 bit.

Edit 2: Other features also work fine in Chrome and Firefox 82

endorphin

harrrrrry using Firefox 82.0.2 on desktop:

harrrrrry it was possible to highlight text and use it as part of a quote.

Still possible (your quotes above and below are all examples).

harrrrrry it was possible to paste an image from the clipboard straight in to a reply

Still possible. I copied and pasted the above image.

harrrrrry Bullet numbering is broken.

harrrrrry Now, after a while. control-B stops doing that and brings up my browser bookmarks instead.

It works fine for me but I am not sure how long you mean by after a while.

harrrrrry @ mentions are partially broken

Still working @harrrrrry (I pressed return to get this @ mention auto completed).

endorphin

harrrrrry I’m testing in firefox 81.0.2 64 bit

Have you updated to 82.0.2? Not that I think that’s the root cause of your reported issues.

bobrobinson

harrrrrry

Quote is working fine for me Full script or partial.
Im on a laptop.
Bob

harrrrrry

danwillen Accessing community through the giffgaff app.

Thanks – I’ve added a note that these features need to be tested on desktop.

harrrrrry

@alex_w Could you have a look at the above

alex_w

harrrrrry Not got a huge amount of time this morning, but Quote is working for me using Chrome on Win 10 laptop.

We’ve made no changes to the platform itself since 21st October, so if these issues are very new for you it’s either something very weird going on or it’s potentially specific to a particular browser update.

harrrrrry

Possibly, but it’s hard to see how a browser update would simultaneously affect the live site but not the preview.

I’ve not accepted any firefox updates since 14th October so unlikely to be that. I possibly made some changes in an addon and will check those, but again, why would it affect the live site but not the preview?

A windows update installed this morning and included a change to webview 2 runtime – but most of these problems were already happening yesterday.

Opera updated itself yesterday, but I’m not sure why this would affect firefox.

harrrrrry

endorphin Still possible (your quotes above and below are all examples).

Those “examples” are all either comparison tests pasted from the preview site, or done in a very roundabout way. For example, to quote (on the live site) I’m having to copy the quote to clipboard, begin an ordinary reply and then paste the quote back into the reply. The quote option isn’t appearing (on the live site) but still works on the preview site.

endorphin

harrrrrry now I’m confused (easily done). Are you reporting the live site where this conversation is being conducted or the preview site?

harrrrrry

Right at the moment, I’ve got the quote back after a skip cache reload. But still have some of the other problems and I can’t restart the browser at the moment because I’m in the middle of a reply.

harrrrrry

endorphin Are you reporting the live site where this conversation is being conducted or the preview site?

The problems were all found on the live site and began yesterday. I was seeing those problems again today, despite the reboot after an overnight windows update.

The comparison examples were captured from the preview site (for example, to show what a quote should look like) followed by a capture from the live site showing what is different.

All images were hosted on the preview site, because at the time I could only paste markup, not actual images.

More is working at the moment, so I suggest you wait for a while and I will see if this happens again.

harrrrrry

@alex_w

I found the problem

It’s a browser extension https://addons.mozilla.org/en-US/firefox/addon/absolute-enable-right-click/ which has settings that are remembered on a per-domain basis. Its setting does not affect subdomains. So, a setting for the community does not affect the preview subdomain.

Also slightly confusing is that although turning on the setting (which was absolute mode) immediately causes those problems – but turning it off does not immediately cease the problem. Plus every time I restarted the browser, the remembered setting was applied to the community domain but not to the preview subdomain.

So, all is working fine provided I keep that option off for community.

alex_w

harrrrrry Awesome, great that you’ve been able to isolate the cause. Given it’s a third party add on there’s probably not much we’ll do ourselves for this, other than flag it over to the open source team (as it will also affect other Flarum communities) for them to take a look to see if the root cause of the compatibility issue is on Flarum’s side or the third party.

Edit: it’s possible it may even already be resolved in Flarum’s Beta 14 update - they’ve got a big upgrade to the Mithril framework. Plausible that the issue is down to a conflict with the old 0.2 Mithril we currently use that may not exist in the new 2.0 Mithril that’s in Beta 14’s release. Beta 14 is already in use on https://discuss.flarum.org/ so you might be able to test the theory there.

harrrrrry

alex_w

Now that the reason is known, it’s not something I would expect, or need, to be fixed within giffgaff’s implementation. I’ve not so far come across anything on giffgaff that needs it enabled in everyday use. I only did it because somebody asked a question about youtube previews a couple of days ago. Youtube sets up its own right click menu, disabling the normal right click options and therefore disabling inspection via the debugger, which is the only reason I had that option on. But It’s useful to know the symptoms and recognise it as a possible cause, in case anybody reports it as a problem and there’s anything similar that might be causing it.

I’ll have a look at that beta release when I get a moment and see whether it changes anything, but I’m guessing the purpose of Absolute Mode is to reinstate the default key processing – probably therefore undoing any special key processing that the running page has set up.

endorphin

harrrrrry , it’s not something I would expect, or need, to be fixed within giffgaff’s implementation

alex_w The site works as expected using the vanilla browser. It’s not up to giffgaff to ensure their site is compatible with every addon/extension (which would be a thankless task).

tankerkiller125

alex_w An important note here is that https://discuss.flarum.org is still on Beta 13 as the Flarum team waits for some community extensions to update.